[pull] master from paritytech:master #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e updated (#10891) The collator protocol contained a race-condition which could manifest as "Collation wasn't advertised". A given peer ("A") can connect before the new authority keys are received via `UpdatedAuthorityIds` (nk -- new key). - T0: peer A connects`PeerConnected` - T1: peer A sends its current view `PeerViewChange` - Peer A wants the block N - T2: `validator_group.should_advertise_to`: checks peer A for key nK (the new key) - We don't have this key stored and therefore return `ShouldAdvertiseTo::NotAuthority` - T3: `UpdatedAuthorityIds` arrives with (peer A, [nK]) At this point, we have the collation, peer A wants to collation, we know peer A is an authority but we never send the collation back. Then, the collation will expire with "Collation wasn't advertised". To close the gap, the `UpdatedAuthorityIds` events will trigger a re-advertisement of collations - note: if the advertisement was already sent, the logic does not resend it (achieved in should_advertise_to). Part of the stabilization of: - #10425 --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
## Summary Fixes a UNIQUE constraint violation when processing blocks after a re-org: ``` UNIQUE constraint failed: transaction_hashes.transaction_hash ``` ## Problem When a blockchain re-org occurs: 1. Block A contains transaction TX1 → stored in `transaction_hashes` 2. Server restarts (clearing the in-memory `block_number_to_hashes` map) 3. Re-org happens, Block B (different hash) now contains the same TX1 4. INSERT fails because TX1 already exists with old block_hash --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )