merge queue: embarking main (2845f4a) and #1006 together#1007
Closed
mergify[bot] wants to merge 3 commits intomainfrom
Closed
merge queue: embarking main (2845f4a) and #1006 together#1007mergify[bot] wants to merge 3 commits intomainfrom
mergify[bot] wants to merge 3 commits intomainfrom
Conversation
After replacing klog with controller-runtime's zap logger, the commonly used -v flag for setting log verbosity no longer works. This adds -v as an alias for --zap-log-level in both the manager and sidecar binaries. Additionally, the sidecar accepts deprecated klog flags (--logtostderr, --alsologtostderr) as no-ops, and preserves --log_file functionality by writing logs to both stderr and the specified file via io.MultiWriter, preventing startup failures in existing deployments that pass these flags via container args. Signed-off-by: Praveen M <m.praveen@ibm.com>
Address errcheck lint failure by wrapping f.Close() in a deferred closure that checks and logs the error. Signed-off-by: Praveen M <m.praveen@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (2845f4a) and #1006 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #1006.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]status-success=build_bundlestatus-success=build_controllerstatus-success=build_sidecarstatus-success=codespellstatus-success=go_mod_vendorstatus-success=go_mod_verifystatus-success=kind_deployRequired conditions to stay in the queue:
#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]