Allow ReclaimSpace to be disabled from StorageClasses#1020
Open
black-dragon74 wants to merge 3 commits intocsi-addons:mainfrom
Open
Allow ReclaimSpace to be disabled from StorageClasses#1020black-dragon74 wants to merge 3 commits intocsi-addons:mainfrom
black-dragon74 wants to merge 3 commits intocsi-addons:mainfrom
Conversation
mergify
bot
requested review from
Madhu-1,
Nikhil-Ladha,
Rakshith-R,
iPraveenParihar,
nixpanic and
yati1998
This patch allows a user to disable reclaimspace from the annotations on the StorageClass. This is required for RWX block mode volumes used in VMs. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74
force-pushed
the
enable-sc-rs
branch
from
a235432 to
34350f0
Compare
nixpanic
requested changes
Apr 15, 2026
Member
nixpanic
left a comment
nixpanic
left a comment
There was a problem hiding this comment.
I guess this makes sense. Only need to add some user facing documentation for the new annotation.
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Member
Author
Done :) |
nixpanic
reviewed
Apr 15, 2026
| kubectl annotate storageclass <SC_NAME> "reclaimspace.csiaddons.openshift.io/enable=false" | ||
| ``` | ||
|
|
||
| This action will disable reclaim space across all PVCs in that StorageClass and remove any existing `ReclaimSpaceCronJob` CRs for PVCs within it. |
Member
There was a problem hiding this comment.
what happens when there is an annotation on a Namespace?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows a user to disable reclaimspace from the annotations
on the StorageClass.
This is required for RWX block mode volumes used in VMs (to prevent sparsify op from blacklisting the actual client) .