Skip to content

fix: remove duplicate CEL rule for secrets #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Nov 26, 2025
Merged

fix: remove duplicate CEL rule for secrets #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion api/csiaddons/v1alpha1/networkfence_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ type NetworkFenceSpec struct {
// Secret is a kubernetes secret, which is required to perform the fence/unfence operation.
// +kubebuilder:deprecatedversion:warning="specifying secrets in networkfence is deprecated, please use networkFenceClassName instead"
// +kubebuilder:validation:Optional
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="secrets are immutable"
Secret SecretSpec `json:"secret,omitempty"`

// Parameters is used to pass additional parameters to the CSI driver.
Expand Down
2 changes: 0 additions & 2 deletions config/crd/bases/csiaddons.openshift.io_networkfences.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,6 @@ spec:
rule: self == oldSelf
type: object
x-kubernetes-validations:
- message: secrets are immutable
rule: self == oldSelf
- message: secret is immutable
rule: self == oldSelf
required:
Expand Down
2 changes: 0 additions & 2 deletions deploy/controller/crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,8 +771,6 @@ spec:
rule: self == oldSelf
type: object
x-kubernetes-validations:
- message: secrets are immutable
rule: self == oldSelf
- message: secret is immutable
rule: self == oldSelf
required:
Expand Down