merge queue: embarking main (0e3fc6c) and #907 together#919
Closed
mergify[bot] wants to merge 6 commits intomainfrom
Closed
merge queue: embarking main (0e3fc6c) and #907 together#919mergify[bot] wants to merge 6 commits intomainfrom
mergify[bot] wants to merge 6 commits intomainfrom
Conversation
This patch moves the variables and functions common across controllers into its own `utils` package. The related tests have been moved as well. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
This patch adds a new controller for PVC objects which differs from existing controller in the following main ways: - Only supports annotations on StorageClasses - Sets us a silent watch on PV objects to optimize lookups. - Uses deterministic naming for child resources to avoid manual house keeping. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
when SchedulePrecedence is set to `StorageClass` Signed-off-by: Niraj Yadav <niryadav@redhat.com>
This patch adds a silent watch on VolumeAttachment objects to avoid unexpected memory consumption due to `List` calls. It is okay to setup a watch in two places as the Informer is shared and managed by the Manager. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
This patch adds a shim layer that is responsible for cleaning up the old resources so that we do not have two CronJobs created for the same underlying PVC. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (0e3fc6c) and #907 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #907.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]status-success=build_bundlestatus-success=build_controllerstatus-success=build_sidecarstatus-success=codespellstatus-success=go_mod_vendorstatus-success=go_mod_verifystatus-success=kind_deployRequired conditions to stay in the queue:
#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]