[Mirror] [5.1.1] 1 Fix graph API to support lvalue execution policies - #12
Open
csiefer2 wants to merge 11 commits into
Open
[Mirror] [5.1.1] 1 Fix graph API to support lvalue execution policies#12csiefer2 wants to merge 11 commits into
csiefer2 wants to merge 11 commits into
Conversation
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
```
/path/to/kokkos/core/src/Kokkos_Macros.hpp:36:6: warning: 'KOKKOS_VERSION' is not defined, evaluates to 0 [-Wundef]
36 | #if !KOKKOS_VERSION_EQUAL(KOKKOS_VERSION_MAJOR, KOKKOS_VERSION_MINOR, \
| ^
/path/to/kokkos/core/src/Kokkos_Macros.hpp:34:4: note: expanded from macro 'KOKKOS_VERSION_EQUAL'
34 | (KOKKOS_VERSION == ((MAJOR)*10000 + (MINOR)*100 + (PATCH)))
| ^
/path/to/kokkos/core/src/Kokkos_Macros.hpp:36:27: warning: 'KOKKOS_VERSION_MAJOR' is not defined, evaluates to 0 [-Wundef]
36 | #if !KOKKOS_VERSION_EQUAL(KOKKOS_VERSION_MAJOR, KOKKOS_VERSION_MINOR, \
| ^
/path/to/kokkos/core/src/Kokkos_Macros.hpp:36:49: warning: 'KOKKOS_VERSION_MINOR' is not defined, evaluates to 0 [-Wundef]
36 | #if !KOKKOS_VERSION_EQUAL(KOKKOS_VERSION_MAJOR, KOKKOS_VERSION_MINOR, \
| ^
/path/to/kokkos/core/src/Kokkos_Macros.hpp:37:27: warning: 'KOKKOS_VERSION_PATCH' is not defined, evaluates to 0 [-Wundef]
37 | KOKKOS_VERSION_PATCH)
| ^
```
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>
Signed-off-by: Damien L-G <dalg24@gmail.com>
[5.1.0] Fix -Wundef warnings about KOKKOS_VERSION* not being defined
[5.1.0] Identify homebrew llvm as KOKKOS_COMPILER_CLANG
Signed-off-by: Seyong Lee <lees2@ornl.gov> Signed-off-by: Christian Trott <crtrott@sandia.gov> Co-authored-by: Daniel Arndt <arndtd@ornl.gov> Co-authored-by: Jakob Bludau <104908666+JBludau@users.noreply.github.com> Co-authored-by: Damien L-G <dalg24+github@gmail.com> Co-authored-by: Nathan Ellingwood <ndellin@sandia.gov> Co-authored-by: Trévis Morvany <63788850+tretre91@users.noreply.github.com> Co-authored-by: Christian Trott <crtrott@sandia.gov>
…8967) * Fix subview construction between managed and unmanaged Views * Add test Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
Signed-off-by: Damien L-G <dalg24@gmail.com>
…ubview_constructor [5.1.0] Fix subview construction between managed and unmanaged Views
Signed-off-by: Damien L-G <dalg24@gmail.com>
Fix graph API to support lvalue execution policies (cherry picked from commit b27b043)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Kokkos to version 5.1.1 and includes a comprehensive changelog for the 5.1.0 release. Key technical improvements include fixing compilation failures when passing lvalue policies to graph nodes by utilizing std::remove_cvref_t, adding a new overload for then_parallel_reduce, and refining compiler macros for Apple Clang. Additionally, the changes address subview construction issues involving unmanaged memory traits and include new unit tests for graph policies and subviews. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated mirror of upstream PR kokkos#9108 Cherry-pick of kokkos#9027 onto
release-candidate-5.1.1.Original PR: kokkos#9027