Skip to content

[Mirror] Add to our READMEs the affiliation logos of Kokkos to LF and HPSF - #17

Open
csiefer2 wants to merge 2 commits into
developfrom
pr-mirror-9287
Open

[Mirror] Add to our READMEs the affiliation logos of Kokkos to LF and HPSF#17
csiefer2 wants to merge 2 commits into
developfrom
pr-mirror-9287

Conversation

@csiefer2

Copy link
Copy Markdown
Owner

Automated mirror of upstream PR kokkos#9287 This is the design with a big Kokkos logo on top and then below the HPSF / LifeCycle Badge / LF Logo below.

crtrott added 2 commits June 17, 2026 13:53
Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md file to center-align the Kokkos logo and add logos for the High Performance Software Foundation (HPSF) and the Linux Foundation. The reviewer identified that some of the newly added image URLs point to GitHub blob HTML pages instead of raw image files, which will prevent them from rendering correctly, and provided suggestions to append ?raw=true to resolve this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread README.md

<div align="center">

[<img src="https://github.com/kokkos/kokkos.github.io/blob/main/assets/img/kokkos-logo.png" width="50%">](https://kokkos.org)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The image URL points to the GitHub blob HTML page instead of the raw image file, which prevents the image from rendering correctly in the README. Please append ?raw=true to the URL.

Suggested change
[<img src="https://github.com/kokkos/kokkos.github.io/blob/main/assets/img/kokkos-logo.png" width="50%">](https://kokkos.org)
[<img src="https://github.com/kokkos/kokkos.github.io/blob/main/assets/img/kokkos-logo.png?raw=true" width="50%">](https://kokkos.org)

Comment thread README.md
Comment on lines +10 to +11
[<img src="https://github.com/hpsfoundation/hpsf-logos/blob/main/Logos/PNG/Horizontal/HPSF_horizontal-tagline-color.png"
width="23%" style="vertical-align: middle;">](https://hpsf.io)&emsp;&emsp;&emsp;&emsp;&emsp;&emsp;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The image URL points to the GitHub blob HTML page instead of the raw image file, which prevents the image from rendering correctly in the README. Please append ?raw=true to the URL.

Suggested change
[<img src="https://github.com/hpsfoundation/hpsf-logos/blob/main/Logos/PNG/Horizontal/HPSF_horizontal-tagline-color.png"
width="23%" style="vertical-align: middle;">](https://hpsf.io)&emsp;&emsp;&emsp;&emsp;&emsp;&emsp;
[<img src="https://github.com/hpsfoundation/hpsf-logos/blob/main/Logos/PNG/Horizontal/HPSF_horizontal-tagline-color.png?raw=true"\n width="23%" style="vertical-align: middle;">](https://hpsf.io)&emsp;&emsp;&emsp;&emsp;&emsp;&emsp;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants