[Mirror] Legacy View Removal - #25
Open
csiefer2 wants to merge 5 commits into
Open
Conversation
Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated mirror of upstream PR kokkos#9391 This PR removes the legacy View implementation path and consolidates behavior on the non-legacy/mdspan-based path. Most of the churn is deletions (19 files, +82/-6599), including full removal of legacy mapping/atomic/cuda-view internals and related test coverage that targeted legacy
ViewMapping/ViewOffset/compile-time subview legality machinery.Removed
Kokkos::Implsymbols (explicitly removed in this PR):Kokkos::Impl::DynRankSubviewTagKokkos::Impl::ViewOffset(base template declaration inKokkos_ViewDataAnalysis.hpp)Kokkos::Impl::ViewMappingforward declaration/stub inKokkos_ViewTraits.hppand broad usage paths tied to legacy implementationKokkos::Impl::SubviewLegalArgsCompileTimeusage/tests removedKokkos::Impl::SubviewExtentsusage/tests removedKokkos::Impl::CudaLDGFetchKokkos::Impl::AtomicViewConstTagKokkos::Impl::AtomicDataElementKokkos::Impl::AtomicViewDataHandleKokkos::Impl::ParseViewExtentsKokkos::Impl::ApplyExtentKokkos::Impl::_parse_view_extents_impl::*helpers (internal parse machinery)Header files removed:
core/src/Cuda/Kokkos_Cuda_View.hppcore/src/Kokkos_Extents.hppcore/src/View/Kokkos_ViewAtomic.hppcore/src/View/Kokkos_ViewLegacy.hppcore/src/View/Kokkos_ViewMapping.hppNote this doesn't fully prune the code from all
#ifdef KOKKOS_ENABLE_IMPL_VIEW_LEGACYyet. I want to get full test coverage first.