Skip to content

[Mirror] Legacy View Removal - #25

Open
csiefer2 wants to merge 5 commits into
developfrom
pr-mirror-9391
Open

[Mirror] Legacy View Removal#25
csiefer2 wants to merge 5 commits into
developfrom
pr-mirror-9391

Conversation

@csiefer2

Copy link
Copy Markdown
Owner

Automated mirror of upstream PR kokkos#9391 This PR removes the legacy View implementation path and consolidates behavior on the non-legacy/mdspan-based path. Most of the churn is deletions (19 files, +82/-6599), including full removal of legacy mapping/atomic/cuda-view internals and related test coverage that targeted legacy ViewMapping/ViewOffset/compile-time subview legality machinery.

Removed Kokkos::Impl symbols (explicitly removed in this PR):

  • Kokkos::Impl::DynRankSubviewTag
  • Kokkos::Impl::ViewOffset (base template declaration in Kokkos_ViewDataAnalysis.hpp)
  • Kokkos::Impl::ViewMapping forward declaration/stub in Kokkos_ViewTraits.hpp and broad usage paths tied to legacy implementation
  • Kokkos::Impl::SubviewLegalArgsCompileTime usage/tests removed
  • Kokkos::Impl::SubviewExtents usage/tests removed
  • Kokkos::Impl::CudaLDGFetch
  • Kokkos::Impl::AtomicViewConstTag
  • Kokkos::Impl::AtomicDataElement
  • Kokkos::Impl::AtomicViewDataHandle
  • Kokkos::Impl::ParseViewExtents
  • Kokkos::Impl::ApplyExtent
  • Kokkos::Impl::_parse_view_extents_impl::* helpers (internal parse machinery)

Header files removed:

  • core/src/Cuda/Kokkos_Cuda_View.hpp
  • core/src/Kokkos_Extents.hpp
  • core/src/View/Kokkos_ViewAtomic.hpp
  • core/src/View/Kokkos_ViewLegacy.hpp
  • core/src/View/Kokkos_ViewMapping.hpp

Note this doesn't fully prune the code from all #ifdef KOKKOS_ENABLE_IMPL_VIEW_LEGACY yet. I want to get full test coverage first.

crtrott added 5 commits July 30, 2026 14:16
Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>
Signed-off-by: Christian Trott <crtrott@sandia.gov>
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants