[Mirror] [5.1.1] 1 Fix: Correct type reference in IndexTypeTrait error reporting - #6
Open
csiefer2 wants to merge 11 commits into
Open
[Mirror] [5.1.1] 1 Fix: Correct type reference in IndexTypeTrait error reporting#6csiefer2 wants to merge 11 commits into
csiefer2 wants to merge 11 commits into
Conversation
Signed-off-by: Damien L-G <dalg24@gmail.com>
Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
```
/path/to/kokkos/core/src/Kokkos_Macros.hpp:36:6: warning: 'KOKKOS_VERSION' is not defined, evaluates to 0 [-Wundef]
36 | #if !KOKKOS_VERSION_EQUAL(KOKKOS_VERSION_MAJOR, KOKKOS_VERSION_MINOR, \
| ^
/path/to/kokkos/core/src/Kokkos_Macros.hpp:34:4: note: expanded from macro 'KOKKOS_VERSION_EQUAL'
34 | (KOKKOS_VERSION == ((MAJOR)*10000 + (MINOR)*100 + (PATCH)))
| ^
/path/to/kokkos/core/src/Kokkos_Macros.hpp:36:27: warning: 'KOKKOS_VERSION_MAJOR' is not defined, evaluates to 0 [-Wundef]
36 | #if !KOKKOS_VERSION_EQUAL(KOKKOS_VERSION_MAJOR, KOKKOS_VERSION_MINOR, \
| ^
/path/to/kokkos/core/src/Kokkos_Macros.hpp:36:49: warning: 'KOKKOS_VERSION_MINOR' is not defined, evaluates to 0 [-Wundef]
36 | #if !KOKKOS_VERSION_EQUAL(KOKKOS_VERSION_MAJOR, KOKKOS_VERSION_MINOR, \
| ^
/path/to/kokkos/core/src/Kokkos_Macros.hpp:37:27: warning: 'KOKKOS_VERSION_PATCH' is not defined, evaluates to 0 [-Wundef]
37 | KOKKOS_VERSION_PATCH)
| ^
```
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>
Signed-off-by: Damien L-G <dalg24@gmail.com>
[5.1.0] Fix -Wundef warnings about KOKKOS_VERSION* not being defined
[5.1.0] Identify homebrew llvm as KOKKOS_COMPILER_CLANG
Signed-off-by: Seyong Lee <lees2@ornl.gov> Signed-off-by: Christian Trott <crtrott@sandia.gov> Co-authored-by: Daniel Arndt <arndtd@ornl.gov> Co-authored-by: Jakob Bludau <104908666+JBludau@users.noreply.github.com> Co-authored-by: Damien L-G <dalg24+github@gmail.com> Co-authored-by: Nathan Ellingwood <ndellin@sandia.gov> Co-authored-by: Trévis Morvany <63788850+tretre91@users.noreply.github.com> Co-authored-by: Christian Trott <crtrott@sandia.gov>
…8967) * Fix subview construction between managed and unmanaged Views * Add test Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
Signed-off-by: Damien L-G <dalg24@gmail.com>
…ubview_constructor [5.1.0] Fix subview construction between managed and unmanaged Views
Signed-off-by: Damien L-G <dalg24@gmail.com>
Fix: Correct type reference in IndexTypeTrait error reporting (cherry picked from commit 7d23234)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Kokkos to version 5.1.1, introduces a comprehensive changelog for the 5.1.0 release, and includes several bug fixes and core enhancements. Key improvements include fixing the error reporting logic in IndexTypeTrait, adding explicit pointer casts in BasicView subview construction, and refining compiler detection for Apple Clang. New unit tests for unmanaged subviews were also added. The review feedback highlights several issues in the CHANGELOG.md, specifically regarding typos, formatting inconsistencies, and mismatched PR links, and suggests adding a section for version 5.1.1 to match the version bump in the build system.
| @@ -1,4 +1,60 @@ | |||
| # CHANGELOG | |||
| ## 5.1.0 | |||
There was a problem hiding this comment.
Since this PR bumps the version to 5.1.1 in CMakeLists.txt, a new section for 5.1.1 should be added at the top of the changelog to document the fixes included in this release candidate (such as the IndexTypeTrait error reporting fix).
| * Enforce failure when exceeding team_size_max and scratch_size_max checks [\#7445](https://github.com/kokkos/kokkos/pull/7445) | ||
| * Enable MPI detection with PALS [\#8895](https://github.com/kokkos/kokkos/pull/8895) | ||
| * Add simd memory permute functions [\#8775](https://github.com/kokkos/kokkos/pull/8775) | ||
| * Performance improvements using `MDRangePolicy` with `CUDA`, `HIP` and `SYCL` [\#8638](https://github.com/kokkos/kokkos/pull/8638), [\#8731](https://github.com/kokkos/kokkos/pull/8731) |
There was a problem hiding this comment.
There is an extra space after the comma between the two PR links.
Suggested change
| * Performance improvements using `MDRangePolicy` with `CUDA`, `HIP` and `SYCL` [\#8638](https://github.com/kokkos/kokkos/pull/8638), [\#8731](https://github.com/kokkos/kokkos/pull/8731) | |
| * Performance improvements using `MDRangePolicy` with `CUDA`, `HIP` and `SYCL` [\#8638](https://github.com/kokkos/kokkos/pull/8638), [\#8731](https://github.com/kokkos/kokkos/pull/8731) |
| * Enable MPI detection with PALS [\#8895](https://github.com/kokkos/kokkos/pull/8895) | ||
| * Add simd memory permute functions [\#8775](https://github.com/kokkos/kokkos/pull/8775) | ||
| * Performance improvements using `MDRangePolicy` with `CUDA`, `HIP` and `SYCL` [\#8638](https://github.com/kokkos/kokkos/pull/8638), [\#8731](https://github.com/kokkos/kokkos/pull/8731) | ||
| * Add `Kokkos::norm`for `Kokkos::complex`- similar to `std::norm` [\#8627](https://github.com/kokkos/kokkos/pull/8927) |
There was a problem hiding this comment.
There are typos and a mismatched PR link in this entry. normfor should be norm for, complex- should be complex -, and the PR number in the text should match the link URL (kokkos#8927).
Suggested change
| * Add `Kokkos::norm`for `Kokkos::complex`- similar to `std::norm` [\#8627](https://github.com/kokkos/kokkos/pull/8927) | |
| * Add Kokkos::norm for Kokkos::complex - similar to std::norm [\#8927](https://github.com/kokkos/kokkos/pull/8927) |
| * Performance improvements using `MDRangePolicy` with `CUDA`, `HIP` and `SYCL` [\#8638](https://github.com/kokkos/kokkos/pull/8638), [\#8731](https://github.com/kokkos/kokkos/pull/8731) | ||
| * Add `Kokkos::norm`for `Kokkos::complex`- similar to `std::norm` [\#8627](https://github.com/kokkos/kokkos/pull/8927) | ||
| * Use neon and sve SIMD instructions if `nvcc` supports them [\#8667](https://github.com/kokkos/kokkos/pull/8667) | ||
| * Expand math support: complete the implementation of all remaining math functions and increase half-type support [\#8595](https://github.com/kokkos/kokkos/pull/8789) [\#8858](https://github.com/kokkos/kokkos/pull/8858) [\#8873](https://github.com/kokkos/kokkos/pull/8873) [\#8712](https://github.com/kokkos/kokkos/pull/8712) [\#8827](https://github.com/kokkos/kokkos/pull/8827) [\#8819](https://github.com/kokkos/kokkos/pull/8819) [\#8719](https://github.com/kokkos/kokkos/pull/8719) [\#8863](https://github.com/kokkos/kokkos/pull/8863) [\#8862](https://github.com/kokkos/kokkos/pull/8862) [\#8778](https://github.com/kokkos/kokkos/pull/8778) [\#8891](https://github.com/kokkos/kokkos/pull/8891) |
There was a problem hiding this comment.
The first PR number in the text (kokkos#8595) does not match the link URL (kokkos#8789).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated mirror of upstream PR kokkos#9114 Cherry-pick of kokkos#9085 onto
release-candidate-5.1.1.Original PR: kokkos#9085