Make GPU NDT covariance updates atomic under contention#9
Open
fredfrog78 wants to merge 2 commits intomasterfrom
Open
Make GPU NDT covariance updates atomic under contention#9fredfrog78 wants to merge 2 commits intomasterfrom
fredfrog78 wants to merge 2 commits intomasterfrom
Conversation
Author
|
Closing for now per review request: will resubmit after dependencies are fixed and tests pass end-to-end. |
Author
|
Maintainer note: Please run maintainer-side GPU/runtime validation before merge on supported targets (e.g. CUDA and/or OpenCL 2.0+ environments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
covarianceHitNdtso only one thread owns each voxel update, including an ungrouped-sample fallback pathgrouped_sampleskernel argument fromGpuNdtMapso the kernel can choose fast grouped traversal vs safe ungrouped ownership scanNdt.HitCountUngrouped)Files changed
ohmgpu/gpu/CovarianceHitNdt.clohmgpu/GpuNdtMap.cpptests/ohmtestgpu/GpuNdtTests.cppcmake/Findglm.cmakeohm/CovarianceVoxel.hohmgpu/private/GpuMapDetail.cppTest results run locally (Apple M3 Pro, OpenCL 1.2)
cmake -S . -B build3 -DOHM_FEATURE_TEST=ON -DOHM_SYSTEM_GTEST=ONcmake --build build3 --target ohmtestocl -j8./build3/bin/ohmtestocl '--gtest_filter=Ndt.*'./build3/bin/ohmtestoclhas 2 failures:Tsdf.BasicTsdf.TruncationThese TSDF failures are due to the local OpenCL runtime limitation (
cl2Metal/ OpenCL 1.2 lacks required 64-bit atomics), not this NDT change.Maintainer request before merge
Please run maintainer validation on a supported GPU/runtime (e.g. CUDA target and/or OpenCL 2.0+ environment) before merge, including:
ohmtestocl(or equivalent supported OpenCL target)ohmtestcudawhere available