-
Notifications
You must be signed in to change notification settings - Fork 10
Add slot descriptions, matcher randomness #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
csm_web
|
Project |
csm_web
|
Branch Review |
master
|
Run status |
|
Run duration | 02m 18s |
Commit |
|
Committer | Alec Li |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
84
|
View all changes introduced in this branch ↗︎ |
5afad51
to
9dd5d6a
Compare
f9629c9
to
65b3442
Compare
c5df64c
to
59a0884
Compare
59a0884
to
113ffe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things. I'm not sure which should be addressed in this PR or another PR.
- The precommit check is failing.
- It would be nice if the mentor side of the matcher had the descriptions on the tiles instead of only visible if you click on the tile -- otherwise, mentors have to click through the tiles to find the description. Or some other visual indicator of a description.
- The save button on the section edit page is always gray -- I think it should be green.
- The bulk editing feature on the section edit page only edits capacity and description, not section time. Should it edit section time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this PR should be prioritized over calendar as we need the description changes to be merged in before elaine and i make too much progress on the affinity section pop-up
+1 to edward's comments
Newest changes should resolve the aforementioned comments:
Regarding the For now, we can just ignore the pre-commit failures in this PR, and #521 can be merged into master first if we want to maintain the passing CI on master. |
662cb4c
to
cc2569a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me :) ty Alec
4075c2a
to
2e2efab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent work alec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent work alec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok LGTM! I'll put more QOL feedback on another issue for someone to one day implement...
* Add matcher slot description, reformat match solver * Add randomness to matcher assignment generation * Set default description for matcher util * Add description to event display, add ability to bulk edit times * Add scrolling to matcher confirm modal content
Closes #466.
Matcher slots currently have no special metadata that coordinators can use to indicate special sections with---this information needs to be communicated to mentors separately. Adding a description to slots allows for this metadata to be embedded within the matcher, so mentors can see whether sections have any special tags (ex. NPE, affinity section, etc.) prior to filling availability.
Secondly, this PR also adds some randomness to the matcher algorithm, randomly shuffling the lists of mentors/slots/preferences so that tiebreaks happen approximately uniformly.