Skip to content

Conversation

@dcb314
Copy link
Contributor

@dcb314 dcb314 commented Oct 26, 2023

More cppcheck changes.

More cppcheck changes.
@jxyang
Copy link
Member

jxyang commented Oct 26, 2023

Could you combine the changes in one PR?

@dcb314
Copy link
Contributor Author

dcb314 commented Oct 27, 2023

Sorry no. I am new to the github GUI and git and still blundering about
without much idea what I am doing. The documentation isn't much help,
so it seems to be just a case of pressing buttons and seeing what happens.

If you know how to do the combination, go ahead.

I still have 27 file changes locally which I need to get into the github.

@jxyang
Copy link
Member

jxyang commented Oct 27, 2023

Merging the .h file and the .cpp file separately will break the build pipeline. I saw you have a PR with multiple files changed: #155. Please follow the same process.

@dcb314
Copy link
Contributor Author

dcb314 commented Oct 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants