Police Party List Component #62
Conversation
…eddedMap.tsx. this is using the google maps API, using a personal API key that I would love to change.
…react-google-map). Created example map of Syndey with map pointers to different locations.
Test Results Summary281 tests +86 281 ✅ +86 7s ⏱️ +3s Results for commit 4aaebde. ± Comparison against base commit 9e07ee6. This pull request removes 2 and adds 88 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Needs styling changes that I have yet to do. I can implement it with the high-fi wire frame. |
naasanov
left a comment
naasanov
left a comment
There was a problem hiding this comment.
Will probably have to redo the PartyList component. And some other small changes
…into mason-party-dropdown
| </div> | ||
| ); | ||
| }; | ||
| const PoiMarkers = ({ pois }: PoiMarkersProps) => { |
There was a problem hiding this comment.
Looks like active poi (which I assume is the functionality for different pin on search address?) isn't implemented
| position={selectedPoi.location} | ||
| onCloseClick={() => setSelectedPoi(null)} | ||
| > | ||
| <div>{selectedPoi.key}</div> |
There was a problem hiding this comment.
Should show a readable short address (e.g. 123 Main Street Unit 15) instead of the key
| } | ||
| type Poi = { key: string; location: google.maps.LatLngLiteral }; | ||
|
|
||
| const EmbeddedMap = ({ parties, activeParty }: EmbeddedMapProps) => { |
There was a problem hiding this comment.
I see that activeParty is of type Party. Assuming that activeParty is supposed to represent the search address, a reminder that the searched address won't always be a party. Ideally we would pass in an object with just the lat lng of the searched party and put a special pin there, zooming into that spot on the map with 0.25 mile radius. Also this object should be nullable for the state when there is no searched party.
…m/cssgunc/party-registration into mason-party-dropdown
Minor change to parties Co-authored-by: Nicolas Asanov <[email protected]>
Created drop-down menu for searching for Police Parties in a certain area.
Changes:
Created component called PartyList that is a scrollable dropdown that receives a text query and searches it's inputted list of parties for that query. It then displays the first and last name of the first contact, as well as an address. Styling and data were chatted and can be changed, but core functionality was my own, so let me know if anything needs to be changed.
Closes #45