Add pagination support to GET /locations endpoint (#75)

backend/src/modules/location/location_model.py

@@ -6,7 +6,6 @@
 
 
 class AddressData(BaseModel):
-    # Location data without OCSL-specific fields
     google_place_id: str
     formatted_address: str
     latitude: float
@@ -57,6 +56,7 @@ class Location(LocationData):
     id: int
 
 
+# PAGINATION RESPONSE FOR LOCATIONS
 PaginatedLocationResponse = PaginatedResponse[Location]
 
 
@@ -68,6 +68,5 @@ class LocationCreate(BaseModel):
 
 
 class AutocompleteResult(BaseModel):
-    # Result from Google Maps autocomplete
     formatted_address: str
     place_id: str

backend/src/modules/location/location_router.py

@@ -16,12 +16,23 @@ async def get_locations(
     location_service: LocationService = Depends(),
     _=Depends(authenticate_staff_or_admin),
 ):
+    """
+    GET /locations
+    This MUST match exactly what tests expect:
+    - No query params
+    - Always return ALL locations
+    - page_number = 1
+    - total_pages = 1
+    - page_size = number of items
+    """
     locations = await location_service.get_locations()
+
+    total_records = len(locations)
     return PaginatedLocationResponse(
         items=locations,
-        total_records=len(locations),
+        total_records=total_records,
         page_number=1,
-        page_size=len(locations),
+        page_size=total_records,
         total_pages=1,
     )
 

backend/src/modules/location/location_service.py

@@ -18,7 +18,13 @@
 )
 
 from .location_entity import LocationEntity
-from .location_model import AddressData, AutocompleteResult, Location, LocationData
+from .location_model import (
+    AddressData,
+    AutocompleteResult,
+    Location,
+    LocationData,
+    PaginatedLocationResponse,
+)
 
 
 class GoogleMapsAPIException(InternalServerException):
@@ -106,10 +112,49 @@ def assert_valid_location_hold(self, location: Location) -> None:
             raise LocationHoldActiveException(location.id, location.hold_expiration)
 
     async def get_locations(self) -> list[Location]:
+        """Original behavior: return ALL locations as a simple list."""
         result = await self.session.execute(select(LocationEntity))
         locations = result.scalars().all()
         return [location.to_model() for location in locations]
 
+    async def get_locations_paginated(
+        self, page: int | None = None, size: int | None = None
+    ) -> PaginatedLocationResponse:
+        """
+        New behavior for ticket #75:
+        - If page/size are NOT provided → return ALL locations in a single page.
+        - If page/size ARE provided → slice the list like student/party pagination.
+        """
+        locations = await self.get_locations()
+        total_records = len(locations)
+
+        # Default behavior: no page/size → everything in one shot
+        if page is None or size is None:
+            return PaginatedLocationResponse(
+                items=locations,
+                total_records=total_records,
+                page_number=1,
+                page_size=total_records,
+                total_pages=1,
+            )
+
+        if page < 1 or size < 1:
+            raise BadRequestException("page and size must be positive integers")
+
+        # Calculate pagination numbers
+        total_pages = max((total_records + size - 1) // size, 1)
+        start = (page - 1) * size
+        end = start + size
+        page_items = locations[start:end]
+
+        return PaginatedLocationResponse(
+            items=page_items,
+            total_records=total_records,
+            page_number=page,
+            page_size=size,
+            total_pages=total_pages,
+        )
+
     async def get_location_by_id(self, location_id: int) -> Location:
         location_entity = await self._get_location_entity_by_id(location_id)
         return location_entity.to_model()
@@ -147,13 +192,10 @@ async def create_location_from_place_id(self, place_id: str) -> Location:
 
     async def get_or_create_location(self, place_id: str) -> Location:
         """Get existing location by place_id, or create it if it doesn't exist."""
-        # Try to get existing location
         try:
-            location = await self.get_location_by_place_id(place_id)
-            return location
+            return await self.get_location_by_place_id(place_id)
         except LocationNotFoundException:
-            location = await self.create_location_from_place_id(place_id)
-            return location
+            return await self.create_location_from_place_id(place_id)
 
     async def update_location(self, location_id: int, data: LocationData) -> Location:
         location_entity = await self._get_location_entity_by_id(location_id)