Table Backend Integration #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naasanov
requested changes
Nov 19, 2025
Collaborator
naasanov
left a comment
naasanov
left a comment
There was a problem hiding this comment.
A couple requests. Code looks great so far. Probably hold off on extending to other tables for now cuz of the modularization requests, but I will take a look at the fixes as soon as possible after you push them
naasanov
requested changes
Nov 19, 2025
Collaborator
naasanov
left a comment
naasanov
left a comment
There was a problem hiding this comment.
Only a couple comments. Aside from that there are some other things like optimistic rendering but we can leave that for extra tickets after we get the main impl in. You are good to start extending to the rest of the tables once you get those fixes in.
…into calebyhan/table-backend-integration
…into calebyhan/table-backend-integration
naasanov
approved these changes
Nov 20, 2025
| } | ||
| } | ||
|
|
||
| async getLocations(): Promise<PaginatedLocationResponse> { |
Collaborator
There was a problem hiding this comment.
Need backend -> frontend types mapping
| return { | ||
| id: "1", | ||
| name: "Admin User", | ||
| email: "[email protected]", |
Collaborator
There was a problem hiding this comment.
Reverting back to what it is in main
Suggested change
| email: "[email protected]", | |
| email: "[email protected]", | |
| accessToken: "fake-access-token-for-dev", | |
| refreshToken: "fake-refresh-token-for-dev", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the backend is mostly done, we can integrate all CRUD functions into the table.
Changes:
route.ts: fixed to accomodate backend mock authpage.tsx: demo page for student tableDeleteConfirmDialog.tsx: sample dialog popup for deleting entry, just as sample so intended to be replaced laterStudentTable.tsx: component for the table itselfStudentTableCreateEdit.tsx: edited to change for the updated call/text pref enumTableTemplate.tsx: these changes might be in progress in a different pr, or not necessary at all, need review on thisstudentService.ts: service for all the table functionsstudent.ts: paginated response typeCloses #81