Skip to content

Conversation

@maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 15, 2025

No description provided.

@FrancaCassol
Copy link
Collaborator

I think the check is fine, I would not go back. We do not want to do baseline correction offline anymore

@maxnoe
Copy link
Member Author

maxnoe commented Jul 15, 2025

I will let @moralejo comment, but I think this is needed for current operations and for analyzing historical data with current lstchain.

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (d9c65f6) to head (5c07eaa).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files          25       25           
  Lines        2693     2693           
=======================================
  Hits         2444     2444           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moralejo
Copy link
Contributor

I will let @moralejo comment, but I think this is needed for current operations and for analyzing historical data with current lstchain.

Yes, I am afraid that is the case. There should be the possibility of re-calibrating the baseline. Is it configurable now?

@FrancaCassol
Copy link
Collaborator

that is true, for old data it is still necessary.

@maxnoe
Copy link
Member Author

maxnoe commented Jul 15, 2025

Yes, I am afraid that is the case. There should be the possibility of re-calibrating the baseline. Is it configurable now?

Yes, we are now back to only looking at the apply_drs4_pedestal_correction configuration option, ignoring the EVB preprocessing flag.

@maxnoe maxnoe merged commit 6576157 into main Jul 15, 2025
6 checks passed
@maxnoe maxnoe deleted the apply_baseline_allways branch July 15, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants