Skip to content

Conversation

@jlenain
Copy link
Collaborator

@jlenain jlenain commented Jul 2, 2025

This PR proposes to clean, streamline and optimize the DQM code. At the moment, I benchmarked a speed-up of a factor 3 on the processing time.

@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 30.83832% with 231 lines in your changes missing coverage. Please review.

Project coverage is 53.36%. Comparing base (3fe9480) to head (237153c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/nectarchain/dqm/charge_integration.py 12.38% 99 Missing ⚠️
src/nectarchain/dqm/mean_waveforms.py 27.08% 35 Missing ⚠️
src/nectarchain/dqm/start_dqm.py 0.00% 31 Missing ⚠️
src/nectarchain/dqm/pixel_timeline.py 39.47% 23 Missing ⚠️
src/nectarchain/dqm/camera_monitoring.py 50.00% 11 Missing ⚠️
src/nectarchain/dqm/dqm_summary_processor.py 66.66% 11 Missing ⚠️
src/nectarchain/dqm/pixel_participation.py 57.14% 9 Missing ⚠️
src/nectarchain/dqm/mean_camera_display.py 53.33% 7 Missing ⚠️
src/nectarchain/dqm/trigger_statistics.py 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   52.25%   53.36%   +1.11%     
==========================================
  Files          76       76              
  Lines        6329     6234      -95     
==========================================
+ Hits         3307     3327      +20     
+ Misses       3022     2907     -115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jlenain added 2 commits July 3, 2025 17:32
…out the DQM, to speed things up and avoid unpacking unnecessary FEB data
…local mode from a different directory than this script
@jlenain jlenain self-assigned this Jul 7, 2025
@jlenain jlenain marked this pull request as ready for review July 7, 2025 15:10
@jlenain jlenain requested a review from hashkar July 7, 2025 15:10
@jlenain jlenain requested a review from vmarandon July 7, 2025 15:10
@jlenain
Copy link
Collaborator Author

jlenain commented Jul 7, 2025

In the end, the speed-up factor is about 4-5, and memory consumption is reduced by a factor ~8 on large runs.

@jlenain jlenain added the enhancement New feature or request label Jul 16, 2025
@jlenain jlenain removed the request for review from vmarandon July 23, 2025 13:37
@jlenain jlenain merged commit 6a50459 into cta-observatory:main Jul 23, 2025
17 of 19 checks passed
@jlenain jlenain deleted the dqm_optimization branch July 23, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants