- 
                Notifications
    You must be signed in to change notification settings 
- Fork 20
Flat Field coefficients computation + the rise and decay times #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ba78e9e
              666a7dc
              60b7db7
              53e2d18
              fbbab0e
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -56,6 +56,8 @@ def __init__( | |
| high_gain=np.zeros((self.npixels, 3)), | ||
| low_gain=np.zeros((self.npixels, 3)), | ||
| pixels_id=self._pixels_id, | ||
| charge=np.zeros((self.npixels, 1)), | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here return the  | ||
| charge_std=np.zeros((self.npixels, 1)), | ||
| ) | ||
|  | ||
| @classmethod | ||
|  | @@ -141,6 +143,9 @@ def run(self, pixels_id: np.ndarray = None, **kwargs) -> None: | |
| (self.gainLG * mask, gainLG_err, gainLG_err) | ||
| ).T | ||
| self._results.is_valid = mask | ||
| log.info("Trying to write charges") | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should make it clear everywhere that these 2 new fields are for the high-gain channel ? E.g. by renaming them  | ||
| self._results.charge = self.meanChargeHG | ||
| self._results.charge_std = self.sigmaChargeHG | ||
|  | ||
| figpath = kwargs.get("figpath", False) | ||
| if figpath: | ||
|  | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to create a
PhotostatContainerto let the gain container in a high abstraction level, thechargeandcharge_stdfileds are not needed in theSPEfitContainerwhich inherits from thegaincontainer