Skip to content

Conversation

@jlenain
Copy link
Collaborator

@jlenain jlenain commented Oct 15, 2025

This PR proposes to change display in SPEalgorithm to a trait, which should hopefully answer to #224.

@jlenain jlenain self-assigned this Oct 15, 2025
@jlenain jlenain added the enhancement New feature or request label Oct 15, 2025
@jlenain jlenain linked an issue Oct 15, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.27%. Comparing base (f004eef) to head (15d905c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   51.79%   51.27%   -0.52%     
==========================================
  Files          78       78              
  Lines        6505     6541      +36     
==========================================
- Hits         3369     3354      -15     
- Misses       3136     3187      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlenain jlenain requested a review from pcorcam October 16, 2025 13:43
Copy link
Contributor

@pcorcam pcorcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jlenain,

Thanks for taking care of this enhancement! The new display_toggle trait works as expected when adding it to the configuration of a FlatFieldSPENominalNectarCAMCalibrationTool and child classes.

Although I approve all current changes, I did find some very minor display keyword-argument syntax in two lines of spe_algorithm.py; see the comment on that file. Could you please have a look before I approve the review? Thanks!

@pcorcam pcorcam merged commit db8aef9 into cta-observatory:main Oct 17, 2025
24 of 27 checks passed
@jlenain jlenain deleted the 224-add-display-as-a-traitlet-in-spealgorithm-component branch October 17, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add display as a traitlet in SPEalgorithm component

2 participants