Skip to content

fix(deploy): etcd using custom registry - #1119

Merged
pandatix merged 1 commit into
mainfrom
fix/deploy/etcd-registry
Dec 13, 2025
Merged

fix(deploy): etcd using custom registry#1119
pandatix merged 1 commit into
mainfrom
fix/deploy/etcd-registry

Conversation

@pandatix

Copy link
Copy Markdown
Member

Resolves #1096

@pandatix pandatix added bug Something isn't working go Pull requests that update Go code lock/etcd When Chall-Manager uses etcd as the distributed lock backend. labels Dec 11, 2025
@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow CI / buf-lint (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 11, 2025, 2:57 PM

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20137334769

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 52.247%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deploy/services/parts/etcd.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/chall-manager-janitor/main.go 8 79.05%
Totals Coverage Status
Change from base Build 20061777137: -0.07%
Covered Lines: 4465
Relevant Lines: 8546

💛 - Coveralls

@pandatix
pandatix merged commit 236a973 into main Dec 13, 2025
17 of 18 checks passed
@pandatix
pandatix deleted the fix/deploy/etcd-registry branch December 13, 2025 13:35
mcbloch pushed a commit to mcbloch/chall-manager that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code lock/etcd When Chall-Manager uses etcd as the distributed lock backend.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: etcd cluster with registry has invalid image format

3 participants