-
Notifications
You must be signed in to change notification settings - Fork 3
Feat all child steps #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Report all child steps in extra property of a step - Include hook, expect, pw:api and test.step steps by default - Add a new configuration option - testStepsOnly - Allow existing behavior to report only 'test.step' steps through 'testStepsOnly' configuration - Add a step's category, duration and location in extra property of the step - Update README to reflect configuration and feature updates - Add 'examples' document for testStepsOnly configuration option BREAKING CHANGE: Include hook, expect, pw:api and test.step steps by default
Fixes #9 |
Hello @apatelia, thank you for the contribution. After testing the changes, we’d like to suggest a few adjustments. Across various test suites, we’ve observed that the default configuration has led to a significant increase in report size, with some reports being approximately 5 times larger in file size and containing 10 times more lines. To address this, we suggest the following configuration options:
This means that, for users on the default configuration, there won't be a significant change in their reports unless they choose to include all steps explicitly. Does this approach align with your expectations and meet the needs of users using BDD? |
Thanks @Ma11hewThomas! It sounds good to me. I will implement it, test it, and then update this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @apatelia, thank you for the contribution.
After testing the changes, we’d like to suggest a few adjustments.
Across various test suites, we’ve observed that the default configuration has led to a significant increase in report size, with some reports being approximately 5 times larger in file size and containing 10 times more lines.
To address this, we suggest the following configuration options:
Option | Default | Description |
---|---|---|
steps | false | Include steps in your report (includes only test steps by default) |
testStepsOnly | true | When steps is enabled, include only test-specific steps |
This means that, for users on the default configuration, there won't be a significant change in their reports unless they choose to include all steps explicitly.
Does this approach align with your expectations and meet the needs of users using BDD?
Hello @Ma11hewThomas, sorry that it took me unexpectedly long to respond to the original change request. I appreciate the testing you have done and the valid point that you have raised about the report being too big. But I think we do not need to introduce additional
I think that setting the |
BREAKING CHANGE:
Include hook, expect, pw:api and test.step steps by default, but is configurable to allow for old behavior of including only test.step.