Fix thread name setting for Apple platform #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: │ │ $SRC_DIR/ros-noetic-cras-cpp-common/src/work/src/thread_utils.cpp:43:3: error: no matching function for call to 'pthread_setname_np' │ │ 43 | pthread_setname_np(pthread_self(), nameBuf); │ │ | ^~~~~~~~~~~~~~~~~~ │ │ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/pthread.h:535:5: note: candidate function not viable: requires 1 arg │ │ ument, but 2 were provided │ │ 535 | int pthread_setname_np(const char*); │ │ | ^ ~~~~~~~~~~~
Member
|
This package was never meant to be compiled on OSX. I see that this is a very little change that would be harmless to integrate, but I can't and won't provide OSX support. Can you do that? I guess this change is coming from Robostack? I don't want to put hurdles in the way, but the general idea of running ROS 1 packages on unsupported platforms seems weird to me, as I like to e.g. use bash scripts and those will only work on Linux. |
Contributor
Author
|
No I can’t maintain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
│ │ $SRC_DIR/ros-noetic-cras-cpp-common/src/work/src/thread_utils.cpp:43:3: error: no matching function for call to 'pthread_setname_np'
│ │ 43 | pthread_setname_np(pthread_self(), nameBuf);
│ │ | ^~~~~~~~~~~~~~~~~~
│ │ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/pthread.h:535:5: note: candidate function not viable: requires 1 arg
│ │ ument, but 2 were provided
│ │ 535 | int pthread_setname_np(const char*);
│ │ | ^ ~~~~~~~~~~~