Docs: extends warning #10032
Open
Docs: extends warning #10032
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a warning to extends keyword to note which keys it doesn't extend
github-actions
bot
added
the
pr:community
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning to extends keyword to note which keys it doesn't extend
Check List
Description of Changes Made (if issue reference is not provided)
The
extendskeyword does not applyrefresh_keyto the cube that's extended, if the base cube is abstract, instead that cube will use the default refresh. There's no indication of this being a bug but the docs don't clarify it. Checking the code it's unclear if this is deliberate but it feels like this would be a clear bug otherwise so assuming it's intended. This clarifies the behaviour to avoid unnecessary cache refreshes.