feat: replace crypto md5 key/version hashing with single function based on xxhash #10314
+394
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #9397
This PR just adds a few commits to create a single function as requested (#9397 (comment)) and test coverage.
In addition to the performance improvements with
xxhash, my motivation was to removemd5crypto as a whole because it's not supported when enabling FIPS mode.Original PR description below
Switch to using faster xxhash for cache keys and versions of data models instead of slow
crypto.createHash('md5').Use the fastest node xxhash implementation, written in ... of course rust :)
Here are some more info for those who is interested: