Skip to content

feat(cubesql): Support PERCENTILE_CONT SQL push down #8697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Sep 11, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR bumps DataFusion, allowing PERCENTILE_CONT aggregate function parsing and planning, and adds SQL push down templates for WITHIN GROUP expression. Related test is included.

Sorry, something went wrong.

@MazterQyou MazterQyou requested review from a team as code owners September 11, 2024 16:21
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 80.73394% with 84 lines in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (1104bde) to head (56ecf0f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...sql/cubesql/src/compile/rewrite/rules/old_split.rs 0.00% 61 Missing ⚠️
.../cubesql/src/compile/engine/df/optimizers/utils.rs 0.00% 20 Missing ⚠️
...ompile/rewrite/rules/wrapper/aggregate_function.rs 95.08% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8697       +/-   ##
===========================================
+ Coverage        0   84.17%   +84.17%     
===========================================
  Files           0      230      +230     
  Lines           0    85112    +85112     
===========================================
+ Hits            0    71639    +71639     
- Misses          0    13473    +13473     
Flag Coverage Δ
cubesql 84.17% <80.73%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou force-pushed the cubesql/percentile-cont branch from ce2065a to f47d340 Compare September 18, 2024 16:30
@MazterQyou MazterQyou requested a review from a team as a code owner September 18, 2024 16:30
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 4:32pm

@MazterQyou MazterQyou force-pushed the cubesql/percentile-cont branch from f47d340 to c16c562 Compare September 18, 2024 16:32
@MazterQyou MazterQyou changed the title chore(cubesql): Support PERCENTILE_CONT planning feat(cubesql): Support PERCENTILE_CONT SQL push down Sep 18, 2024
@MazterQyou MazterQyou force-pushed the cubesql/percentile-cont branch 2 times, most recently from 355ea84 to 4d97b61 Compare June 4, 2025 16:50
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou force-pushed the cubesql/percentile-cont branch from 4d97b61 to 56ecf0f Compare June 4, 2025 19:43
@MazterQyou MazterQyou merged commit 577a09f into master Jun 5, 2025
197 of 202 checks passed
@MazterQyou MazterQyou deleted the cubesql/percentile-cont branch June 5, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants