Skip to content

chore(cubesql): Clean up unreferenced insta snapshots #9130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

mcheshkov
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Sorry, something went wrong.

@mcheshkov mcheshkov force-pushed the cubesql-unused-snapshots branch from 58cde83 to d663a31 Compare January 23, 2025 12:31
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.13%. Comparing base (635ea38) to head (7f62851).
Report is 21 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9130       +/-   ##
===========================================
+ Coverage        0   84.13%   +84.13%     
===========================================
  Files           0      230      +230     
  Lines           0    84625    +84625     
===========================================
+ Hits            0    71199    +71199     
- Misses          0    13426    +13426     
Flag Coverage Δ
cubesql 84.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov force-pushed the cubesql-unused-snapshots branch 4 times, most recently from de99d94 to 63444a8 Compare January 23, 2025 18:20
@KSDaemon KSDaemon force-pushed the cubesql-unused-snapshots branch from 63444a8 to 7f62851 Compare May 30, 2025 12:46
@KSDaemon KSDaemon marked this pull request as ready for review May 30, 2025 12:46
@KSDaemon KSDaemon requested a review from a team as a code owner May 30, 2025 12:46
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@KSDaemon KSDaemon merged commit c3ca3c4 into master Jun 6, 2025
117 of 125 checks passed
@KSDaemon KSDaemon deleted the cubesql-unused-snapshots branch June 6, 2025 15:32
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
* chore(cubesql): Clean up unreferenced insta snapshots

* ci(cubesql): Check unreferenced insta snapshots in CI

* try to combine llvm-cov and insta test run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants