-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(client-core): add signal option to support abort fetch #9539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9539 +/- ##
=======================================
Coverage 57.50% 57.50%
=======================================
Files 165 165
Lines 13504 13504
Branches 2278 2278
=======================================
Hits 7766 7766
Misses 5430 5430
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Alex Vasilev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@woai3c Great! Thank you for your contribution!
…9539) * feat(client-core): add signal option to support abort fetch * test(client-core): add test cases for signal * test(client-core): merge two HttpTransport.test.js files * chore: change the license to MIT Co-authored-by: Alex Vasilev <[email protected]> --------- Co-authored-by: Alex Vasilev <[email protected]>
Check List
Description of Changes Made
This PR adds the ability to abort requests in @cubejs-client/core by introducing support for the AbortController signal. The implementation:
These changes allow users to cancel in-flight requests by using the AbortController API: