fix(client-vue3): prevent heuristic call when initial query is empty in computed property validateQuery #9656
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
vasilev-alex
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
At the moment, if the query is empty in the beginning of the render process, as the query is passed as a prop, the computed property validatedQuery will set the variable skipHeuristics to false on the second computation run even if the query is still empty. When the query is filled afterwards, even though it is the initial query, the heuristic function is called, an changes to the query are made for example adding granularity and order options, which aren't present on the initial query passed. It seems that in vue3 the computed property are triggered more times than before, which resulted in this problem.
The fix prevents that until the query is actually loaded the heuristic function is not called.