Skip to content

feat(schema-compiler): Add support for time dimensions with granularities in multi-stage measures add_group_by #9657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jun 4, 2025

With this fix you can reference time dimension granularity within add_group_by property of multi-stage measure.

      - name: xirr
        multi_stage: true
        sql: "XIRR({total_payments}, {created_at.day})"
        type: number_agg
        add_group_by:
          - created_at.day   # here day is a granularity of created_at dimension

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon marked this pull request as ready for review June 4, 2025 17:23
@KSDaemon KSDaemon requested a review from a team as a code owner June 4, 2025 17:23
@KSDaemon KSDaemon merged commit 6700b43 into master Jun 18, 2025
64 checks passed
@KSDaemon KSDaemon deleted the feat/td-with-grn-in-add-group-by branch June 18, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants