Skip to content

chore(cubestore): Hygiene fix for query cache wait loop for in-progre… #9658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

chore(cubestore): Hygiene fix for query cache wait loop for in-progre… #9658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rust/cubestore/cubestore/src/sql/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,15 @@ impl SqlResultCache {
) -> Result<Arc<DataFrame>, CubeError> {
if let Some(receiver) = &mut receiver {
loop {
// Currently we should never loop -- we only send sender a `Some(_)` value.
receiver.changed().await?;
let x = receiver.borrow();
let x = receiver.borrow_and_update();
let value = x.as_ref();
if let Some(value) = value {
trace!("Using cache for '{}'", query);
return value.clone();
}
log::warn!("Queue query cache is (impossibly) looping for '{}'", query);
}
}
panic!("Unexpected state: wait receiver expected but cache was empty")
Expand Down
Loading