fix: Report more accurate time to APM on heavy used deployments #9667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9667 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 230 230
Lines 85112 85112
=======================================
+ Hits 71639 71647 +8
+ Misses 13473 13465 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chore: fix
ovr
force-pushed
the
feat/correct-time-with-apm
branch
from
8a883be to
21755f6
Compare
Co-authored-by: Konstantin Burkalev <[email protected]>
Co-authored-by: Konstantin Burkalev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is simple: When an
asyncfunction is called in anasyncfunction withawait, the real execution can be delayed to micro tasking in Node.js. It results in incorrect timestamps, which I see in APM.