Skip to content

Allow Modal secret name to be specified in config #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomwhite merged 1 commit into from
Sep 5, 2025
Merged

Allow Modal secret name to be specified in config #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions cubed/runtime/executors/modal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,15 @@
else:
raise ValueError(f"Unrecognized cloud: {cloud}")

if cloud == "aws":
secrets = [modal.Secret.from_name("my-aws-secret")]
elif cloud == "gcp":
secrets = [modal.Secret.from_name("my-googlecloud-secret")]
else:
raise ValueError(f"Unrecognized cloud: {cloud}")
secret_name = executor_options.get("secret", None)
if secret_name is None:
if cloud == "aws":
secret_name = "my-aws-secret"
elif secret_name == "gcp":
secrets_name = "my-googlecloud-secret"
else:
raise ValueError(f"Unrecognized cloud: {cloud}")
secrets = [modal.Secret.from_name(secret_name)]


def check_runtime_memory(spec):
Expand Down Expand Up @@ -155,7 +158,15 @@ def execute_dag(
) -> None:
merged_kwargs = {**self.kwargs, **kwargs}
# remove executor options as they should already have been used in defining the remote functions
for executor_option in ("memory", "retries", "timeout", "cloud", "region"):
for executor_option in (
"memory",
"retries",
"timeout",
"cloud",
"region",
"requirements_file",
"secret",
):
merged_kwargs.pop(executor_option, None)
asyncio_run(
self._async_execute_dag(
Expand Down
1 change: 1 addition & 0 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ Note that `batch_size` is not currently supported for Lithops.
|------------------------------|---------|-------------------------------------------------------------------------------------|
| `cloud` | `"aws"` | The cloud to run on. One of `"aws"` or `"gcp"`. |
| `region` | N/A | The cloud region to run in. This must be set to match the region of your cloud store to avoid data transfer fees. See Modal's [Region selection](https://modal.com/docs/guide/region-selection) page for possible values. |
| `secret` | `"my-aws-secret"` for AWS, `"my-googlecloud-secret"` for Google Cloud | The name of the [Modal secret](https://modal.com/docs/guide/secrets) to use. |
| `retries` | 2 | The number of times to retry a task if it fails. |
| `timeout` | 180 | Tasks that take longer than the timeout will be automatically killed and retried. |
| `enable_output` | False | Print Modal output to stdout and stderr things for debugging. |
Expand Down
Loading