Draft
Conversation
rachitnigam
reviewed
Nov 12, 2024
apps/frisc/test/regfile.fil
Outdated
| data: ['G,'G+1] 32, | ||
| rin1: ['G,'G+1] 5, | ||
| rin2: ['G,'G+1] 5 | ||
| @[G,G+1] reset:1, |
Member
There was a problem hiding this comment.
This seems like old syntax that won't compile. Can we add the frisc tests to the test suite?
rachitnigam
reviewed
Nov 12, 2024
apps/frisc/test/decode.fil
Outdated
| @[G, G+1] funct:8, | ||
| @[G, G+1] isAdd:1, // 1 if add, 0 if sub | ||
| @[G, G+1] isArith:1, // 1 if arith, 0 if log | ||
| @[G, G+1] rf_write:1 |
rachitnigam
requested changes
Nov 12, 2024
Member
rachitnigam
left a comment
rachitnigam
left a comment
There was a problem hiding this comment.
Some of the files have the old syntax. Not sure if that is a merge problem or just out of date code. We should also add testing for this stuff to make sure things compile.
Collaborator
Author
|
I think something got messed up in one of the merges, thanks for pointing out. Planning on updating the tests before merging as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version on main was incomplete. tests disabled for now