Skip to content

Port attributes#486

Merged
UnsignedByte merged 3 commits intomainfrom
port-attribs
Jan 24, 2025
Merged

Port attributes#486
UnsignedByte merged 3 commits intomainfrom
port-attribs

Conversation

@UnsignedByte
Copy link
Collaborator

Adds port attributes of the form

#[attrib]
port: ['G, 'G+1] 32,
...

Also can technically be used within bundle definitions like

bundle #[attrib] bun[3]: for<i> ['G + i, 'G+i+1] 32;

@UnsignedByte
Copy link
Collaborator Author

I should add a test case for this but right now there are no implemented attributes...

@UnsignedByte
Copy link
Collaborator Author

@rachitnigam if there are no problems here I will merge this and start using it in the scheduling pass. My one question remaining is whether it is a good idea to store an Attributes in every port, considering we are trying to lower the size of the actual control elements. ALternatively we would have to create an IndexStore but I am not sure how reasonable that is.

@rachitnigam
Copy link
Member

There is a way to store information associated with a PortIdx that is not a port itself right? Something like a secondary context?

@UnsignedByte UnsignedByte enabled auto-merge (squash) January 24, 2025 20:29
@UnsignedByte UnsignedByte merged commit e0703dd into main Jan 24, 2025
4 checks passed
@UnsignedByte UnsignedByte deleted the port-attribs branch January 24, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants