Conversation
`cargo check`, `cargo clippy`, and `cargo fmt`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously did some checks on Python code; I've updated those to use ruff for listing & formatting, and I've also added some checks for Rust code (
cargo check,cargo clippy, andcargo fmt). Always good for your health!The addition of Clippy revealed several things to fix in our Rust code, so I did that too. I suppressed one interesting lint: the
repr_packed_without_abilint, which warns that the layout of#repr(packed)structs is unstable. That would be a problem if our file formats were meant to be consumed by other tools. That's not currently true, but if it ever is, we should consider switching to the C ABI.