Merged
Conversation
Use the simpler name `fgfa size`, and adjust internal names to match.
This should go to stdout, not stderr. We also don't need to repeat the word "bytes"; this should make the output easier to parse in scripts.
Makes it super simple to get the size (in bytes) of each pool.
This seems nice because they do *almost* the same thing? And it will be more obvious if these two chunks of code get out of sync...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks the command that @johnpalsberg added in #214 to print out the sizes of each part of a FlatGFA data structure. It is cleanly separable from the rest of that PR, and it would be nice to land immediately so we can do proper experiments in measuring file sizes when we make changes (as is the main focus in #214).
I also changed a few things around to make the code simpler, and I folded this functionality into the
toccommand that does almost the same thing. You now dofgfa toc -bto see the the table of contents in byte sizes instead of element counts.Here's an example: