Replace deprecated ::set-output
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodeg
had a problem deploying
to
Publish to Nexus
GitHub Actions
Failure
gaeljw
reviewed
Mar 14, 2025
| @@ -26,7 +26,7 @@ jobs: | |||
| run: | | |||
| version=0.0.$GITHUB_RUN_NUMBER | |||
| echo "ThisBuild / version := \"$version\"" > version.sbt | |||
| echo "::set-output name=version::$version" | |||
| echo "version=$version" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
Do we even need this in the 1st place? I don't see where it's used. I may be missing something obvious. It's been a long time since I wrote this!
There was a problem hiding this comment.
That is indeed a good question.
|
The CI is failing but probably not because of your changes. I'll have a look in the coming days. |
Thank you. |
It's actually caused by the fact that workflow on your branch do not have access to secrets we use to publish to Sonatype. I'm rebasing and merging your PR. Thanks! |
gaeljw
approved these changes
Mar 16, 2025
As per the deprecation warning and explanation at https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Signed-off-by: Dominik Gedon <[email protected]>
gaeljw
had a problem deploying
to
Publish to Nexus
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
As per the deprecation warning and explanation at https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
⚡️ What's your motivation?
See cucumber/common#2150
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Is the changelog entry fine this way?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.