PHP - Introduce Mutation testing #52
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| build | ||
| vendor | ||
| composer.lock | ||
| .phpunit.cache | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "$schema": "vendor/infection/infection/resources/schema.json", | ||
| "source": { | ||
| "directories": [ | ||
| "src", | ||
| ] | ||
| }, | ||
| "mutators": { | ||
| "@default": true | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Cucumber\Gherkin; | ||
|
|
||
| use Cucumber\Messages\Envelope; | ||
| use Cucumber\Messages\Source; | ||
| use Cucumber\Messages\Streams\NdJson\NdJsonStreamWriter; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| final class TestDataTest extends TestCase | ||
| { | ||
| /** | ||
| * @dataProvider provideGoodFeatureFiles | ||
| */ | ||
| public function testTokensAreSameAsTestData(string $fullPath): void | ||
| { | ||
| $result = (new Parser(new TokenFormatterBuilder()))->parse( | ||
| $fullPath, | ||
| new StringTokenScanner(file_get_contents($fullPath)), | ||
| new TokenMatcher(), | ||
| ); | ||
|
|
||
| self::assertStringEqualsFile($fullPath . '.tokens', $result); | ||
| } | ||
|
|
||
| /** | ||
| * @dataProvider provideGoodFeatureFiles | ||
| */ | ||
| public function testAstsAreSameAsTestData(string $fullPath, Source $source): void | ||
| { | ||
| $envelopes = (new GherkinParser( | ||
| predictableIds: true, | ||
| includeSource: false, | ||
| includeGherkinDocument: true, | ||
| includePickles: false, | ||
| ))->parse([$source]); | ||
|
|
||
| self::assertEnvelopesMatchNdJsonFile($envelopes, $fullPath . '.ast.ndjson'); | ||
| } | ||
|
|
||
| /** | ||
| * @dataProvider provideGoodFeatureFiles | ||
| */ | ||
| public function testSourcesAreSameAsTestData(string $fullPath, Source $source): void | ||
| { | ||
| $envelopes = (new GherkinParser( | ||
| predictableIds: true, | ||
| includeSource: true, | ||
| includeGherkinDocument: false, | ||
| includePickles: false, | ||
| ))->parse([$source]); | ||
|
|
||
| self::assertEnvelopesMatchNdJsonFile($envelopes, $fullPath . '.source.ndjson'); | ||
| } | ||
|
|
||
| /** | ||
| * @dataProvider provideGoodFeatureFiles | ||
| */ | ||
| public function testPicklesAreSameAsTestData(string $fullPath, Source $source): void | ||
| { | ||
| $envelopes = (new GherkinParser( | ||
| predictableIds: true, | ||
| includeSource: false, | ||
| includeGherkinDocument: false, | ||
| includePickles: true, | ||
| ))->parse([$source]); | ||
|
|
||
| self::assertEnvelopesMatchNdJsonFile($envelopes, $fullPath . '.pickles.ndjson'); | ||
| } | ||
|
|
||
| /** | ||
| * @dataProvider provideBadFeatureFiles | ||
| */ | ||
| public function testErrorsAreSameAsTestData(string $fullPath, Source $source): void | ||
| { | ||
| $envelopes = (new GherkinParser( | ||
| predictableIds: true, | ||
| includeSource: false, | ||
| includeGherkinDocument: false, | ||
| includePickles: true, | ||
| ))->parse([$source]); | ||
|
|
||
| self::assertEnvelopesMatchNdJsonFile($envelopes, $fullPath . '.errors.ndjson'); | ||
| } | ||
|
|
||
| /** | ||
| * @return iterable<string, array{0: string, 1: Source}> | ||
| */ | ||
| public function provideGoodFeatureFiles(): iterable | ||
| { | ||
| return $this->provideFeatureFiles("good"); | ||
| } | ||
|
|
||
| /** | ||
| * @return iterable<string, array{0: string, 1: Source}> | ||
| */ | ||
| public function provideBadFeatureFiles(): iterable | ||
| { | ||
| return $this->provideFeatureFiles("bad"); | ||
| } | ||
|
|
||
| /** | ||
| * @param 'good'|'bad' $subDir | ||
| * | ||
| * @return iterable<string, array{0: string, 1: Source}> | ||
| */ | ||
| private function provideFeatureFiles(string $subDir): iterable | ||
| { | ||
| foreach (glob(__DIR__ . "/../../../testdata/$subDir/*.feature") as $fullPath) { | ||
| $shortPath = substr($fullPath, strlen(__DIR__ . '/../../')); | ||
|
|
||
| yield $shortPath => [$fullPath, new Source($shortPath, file_get_contents($fullPath))]; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @param iterable<Envelope> $envelopes | ||
| */ | ||
| private static function assertEnvelopesMatchNdJsonFile(iterable $envelopes, string $expectedfile): void | ||
| { | ||
| $output = fopen('php://memory', 'w'); | ||
| NdJsonStreamWriter::fromFileHandle($output)->writeEnvelopes($envelopes); | ||
| rewind($output); | ||
|
|
||
| $actual = stream_get_contents($output); | ||
| $expected = file_get_contents($expectedfile); | ||
|
|
||
| // rather than compare the full file, compare line by line to get better JSON diffs on error | ||
| $actualLines = explode("\n", $actual); | ||
| $expectedLines = explode("\n", $expected); | ||
|
|
||
| self::assertSame(count($actualLines), count($expectedLines)); | ||
|
|
||
| foreach ($actualLines as $i => $actualLine) { | ||
| if ($actualLine !== '') { | ||
| self::assertJsonStringEqualsJsonString($expectedLines[$i], $actualLine); | ||
| } else { | ||
| self::assertEquals($expectedLines[$i], ''); | ||
| } | ||
| } | ||
| } | ||
| } |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can run all the tests in a regular run. The separation between acceptance and unit existed only because we had different methods for testing.