Fix double substitutions of example values in Ruby - #697
Open
raviqqe wants to merge 1 commit into
Open
Conversation
raviqqe
changed the title
raviqqe
marked this pull request as ready for review
August 23, 2026 23:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
The Ruby implementation now substitutes scenario outline example values literally, using the block form of
String#gsub, instead of passing them as replacement patterns.⚡️ What's your motivation?
Every other implementation already substitutes literally. This is Ruby catching up rather than new behavior.
The second argument of
String#gsubis a replacement pattern, not a literal string. Because example values are data, any value holding a backslash before special characters is silently rewritten instead of inserted.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
No, I don't think so.
📋 Checklist: