Skip to content

Allow alphanumeric barcodes #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brycekbargar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow alphanumeric barcodes #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6956751
Allow strings but parse ints by default
brycekbargar Oct 2, 2025
5628c91
Add the new env variable to the .env example
brycekbargar Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ OKAPI_URL=CHANGEME
OKAPI_TENANT=CHANGEME
OKAPI_USER=CHANGEME
OKAPI_PASSWORD=CHANGEME
BARCODE_REGEX=CHANGEORREMOVEME
8 changes: 6 additions & 2 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from dotenv import load_dotenv
from fastapi import APIRouter, FastAPI, Request, Response
from fastapi import APIRouter, FastAPI, HTTPException, Request, Response
from fastapi.routing import APIRoute
from json2xml import json2xml
from json2xml.utils import readfromstring
Expand Down Expand Up @@ -40,11 +40,15 @@ async def read_root():

@router.get("/items/{barcode}")
async def read_item(
barcode: int,
barcode: str,
format: Optional[str] = "xml",
replace: Optional[bool] = True,
transform: Optional[bool] = True,
):
barcode_rx = os.getenv('BARCODE_REGEX', r'\d+')
if re.fullmatch(barcode_rx, barcode) is None:
raise HTTPException(status_code=400, detail="invalid barcode")

url = f"{os.getenv('OKAPI_URL')}/inventory/items"
params = {"query": f"(barcode=={barcode})"}
headers = {
Expand Down