fix: ignore undefined and null params on modifiers

.github/workflows/test.yml

@@ -7,11 +7,11 @@ jobs:
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        meteor: [1.12.2, 2.6.1, 2.7.3, 2.8.1, 2.12]
+        meteor: [1.12.2, 2.8.1, 2.12, 2.15]
         redis-version: [4, 5, 6, 7]
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Start Redis
         uses: supercharge/[email protected]
@@ -26,7 +26,7 @@ jobs:
         run: |
           meteor create --release ${{ matrix.meteor }} --bare test
           cd test
-          meteor npm i --save [email protected] simpl-schema chai
+          meteor npm i --save [email protected] simpl-schema@1.13.1 chai
       - name: Test
         working-directory: ./test
         run: METEOR_PACKAGE_DIRS="../" TEST_BROWSER_DRIVER=puppeteer meteor test-packages --raw-logs --once --driver-package meteortesting:mocha ../

lib/utils/getFields.js

@@ -1,3 +1,5 @@
+import isNil from "./isNil";
+
 /**
  * Taken from: https://github.com/Meteor-Community-Packages/meteor-collection-hooks/blob/master/collection-hooks.js#L194 and modified.
  * @param mutator
@@ -7,7 +9,7 @@ export default function getFields(mutator) {
     var fields = [];
     var topLevelFields = [];
 
-    Object.entries(mutator).forEach(function ([op, params]) {
+    Object.entries(mutator).filter(([_, params]) => !isNil(params)).forEach(function ([op, params]) {
         if (op[0] == '$') {
             Object.keys(params).forEach(function (field) {
                 // record the field we are trying to change

lib/utils/isNil.js

@@ -0,0 +1,3 @@
+export default function isNil(value) {
+    return value === null || value === undefined;
+}

lib/utils/testing/getFields.test.js

@@ -37,4 +37,24 @@ describe('Unit # getFields', function () {
     it('Should properly detected top level fields', function () {
         // TODO
     })
-});
+
+    it('Should ignore null or undefined params', function () {
+        let fields = run({
+            $set: {
+                a: {
+                    d: 1
+                },
+                'profile.test': 1
+            },
+            $inc: {
+                b: 1
+            },
+            $addToSet: undefined
+        }).fields;
+
+        assert.lengthOf(fields, 3);
+        assert.include(fields, 'a');
+        assert.include(fields, 'b');
+        assert.include(fields, 'profile.test');
+    })
+});

lib/utils/testing/index.js

@@ -1,2 +1,3 @@
 import './getFields.test';
-import './extractIdsFromSelector.test';
+import './extractIdsFromSelector.test';
+import './isNil.test';

lib/utils/testing/isNil.test.js

@@ -0,0 +1,13 @@
+import { assert } from 'chai';
+import run from '../isNil';
+
+describe('Unit # isNil', function () {
+    it('Should work', function () {
+        assert.isTrue(run(null));
+        assert.isTrue(run(undefined));
+        assert.isFalse(run(1));
+        assert.isFalse(run('1'));
+        assert.isFalse(run({}));
+        assert.isFalse(run([]));
+    });
+});

package.js

@@ -1,6 +1,6 @@
 Package.describe({
     name: 'cultofcoders:redis-oplog',
-    version: '2.2.1',
+    version: '2.2.2',
     // Brief, one-line summary of the package.
     summary: "Replacement for Meteor's MongoDB oplog implementation",
     // URL to the Git repository containing the source code for this package.
@@ -17,7 +17,7 @@ Npm.depends({
 });
 
 Package.onUse(function(api) {
-    api.versionsFrom(['1.12.2', '2.8.1', '2.12']);
+    api.versionsFrom(['1.12.2', '2.8.1', '2.13', '2.15']);
     api.use([
         'underscore',
         'ecmascript',