Open
Conversation
…on hooks bypass Rewrites ObserveMultiplex.js to match Meteor 3.4 fire-and-forget callback semantics, updates observeChanges.js to use the 4-param signature, and uses collection.direct in ObservableCollection to prevent collection hooks from re-triggering on already-processed selectors. Changes: - ObserveMultiplex.js: Full ES class rewrite with synchronous _isReady, initialAddsSentResolver, and nonMutatingCallbacks support - observeChanges.js: 4-param signature, removed _noYieldsAllowed, register multiplexer after driver init - ObservableCollection.js: Use collection.direct to bypass collection hooks that fail outside their original context - package.js: Added Meteor 3.3 and 3.4 to versionsFrom
|
Hey @StorytellerCZ could you help us here or point to someone that could merge this? |
Collaborator
|
@harryadel please add 3.4 to the test targets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites ObserveMultiplex.js to match Meteor 3.4 fire-and-forget callback semantics, updates observeChanges.js to use the 4-param signature, and uses collection.direct in ObservableCollection to prevent collection hooks from re-triggering on already-processed selectors.
Changes: