Support React 19 for Next 15 and React 19 upgrade in consumer apps #5552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b98a136 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vietanhtran16
commented
Mar 5, 2025
vietanhtran16
commented
Mar 5, 2025
vietanhtran16
commented
Mar 5, 2025
vietanhtran16
changed the title
|
A bunch of tests are failing. I reckon it might be because of mismatch react version from possibly storybook? I also noticed react and react dom as dependency in the root package.json - are they needed there? |
ryanseddon
force-pushed
the
viet/react-19-peer-deps
branch
2 times, most recently
from
79c5067 to
6303faf
Compare
ryanseddon
force-pushed
the
viet/react-19-peer-deps
branch
from
7dd6d47 to
7a6805f
Compare
* chore: Ignore peerDep warnings for older packages Target specific packages so as not to ignore valid warnings we can ignore * chore: add react popper * chore: add popper core * chore: add changeset and order packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Request PR reviews on Slack
Please reach out to the design system team on Slack in
#prod_design_systemfor PR reviews. GitHub notifications (e.g. from tagging a person) are not actively monitored.Why
To prepare for our Nextjs 15 and React 19 upgrade, I created this PR to test it out. My findings has been documented here
What