Skip to content

Conversation

@xphir
Copy link
Contributor

@xphir xphir commented Apr 23, 2025

Purpose

This pull request improves shell script configurations, fixes file references, and enhances code readability:

  • Enabled external-sources in .shellcheckrc to follow external file references.
  • Corrected shellcheck file paths for shared.bash and steps.bash in command.
  • Fixed a typo ("fragements" → "fragments") and simplified metadata retrieval logic in command.
  • Added a shellcheck directive in steps.bash to handle dynamic sourcing of environment files.

@ctgardner ctgardner requested a review from a team April 23, 2025 23:50
@madobrien
Copy link

Thanks for the fixups!

@madobrien madobrien merged commit 47b301e into main Apr 29, 2025
1 check passed
@madobrien madobrien deleted the es/small-fixes branch April 29, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants