Skip to content

Add Puppet CA certificate to system truststore #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willaerk merged 1 commit into from
Jan 21, 2025
Merged

Add Puppet CA certificate to system truststore #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions manifests/ca_certificates.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
class profiles::ca_certificates (
Variant[String, Array[String]] $disabled_ca_certificates = [],
Boolean $puppet_ca = true,
Boolean $publiq_development_ca = false
) inherits ::profiles {

Expand All @@ -21,6 +22,22 @@
}
}

file { 'Puppet CA certificate directory':
ensure => 'directory',
path => '/usr/local/share/ca-certificates/puppet'
}

file { 'Puppet CA certificate':
ensure => $puppet_ca ? {
true => 'file',
false => 'absent'
},
path => '/usr/local/share/ca-certificates/puppet/puppet-ca.crt',
source => '/etc/puppetlabs/puppet/ssl/certs/ca.pem',
require => File['Puppet CA certificate directory'],
notify => Exec['Update CA certificates']
}

exec { 'Update CA certificates':
command => 'update-ca-certificates',
path => [ '/usr/local/bin', '/usr/bin', '/usr/sbin', '/bin'],
Expand Down
31 changes: 29 additions & 2 deletions spec/classes/ca_certificates_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

it { is_expected.to contain_class('profiles::ca_certificates').with(
'disabled_ca_certificates' => [],
'puppet_ca' => true,
'publiq_development_ca' => false
) }

Expand All @@ -20,16 +21,31 @@

it { is_expected.to have_augeas_resource_count(0) }

it { is_expected.to contain_file('Puppet CA certificate directory').with(
'ensure' => 'directory',
'path' => '/usr/local/share/ca-certificates/puppet'
) }

it { is_expected.to contain_file('Puppet CA certificate').with(
'ensure' => 'file',
'path' => '/usr/local/share/ca-certificates/puppet/puppet-ca.crt',
'source' => '/etc/puppetlabs/puppet/ssl/certs/ca.pem'
) }

it { is_expected.to contain_exec('Update CA certificates').with(
'command' => 'update-ca-certificates',
'path' => [ '/usr/local/bin', '/usr/bin', '/usr/sbin', '/bin'],
'refreshonly' => true
) }

it { is_expected.to contain_file('Puppet CA certificate').that_requires('File[Puppet CA certificate directory]') }
it { is_expected.to contain_file('Puppet CA certificate').that_notifies('Exec[Update CA certificates]') }
end

context "with disabled_ca_certificates => 'foobar'" do
context "with disabled_ca_certificates => 'foobar' and puppet_ca => false" do
let(:params) { {
'disabled_ca_certificates' => 'foobar'
'disabled_ca_certificates' => 'foobar',
'puppet_ca' => false
} }

it { is_expected.not_to contain_apt__source('publiq-tools') }
Expand All @@ -43,13 +59,24 @@
'changes' => 'set *[.= \'foobar\'] \'!foobar\'',
) }

it { is_expected.to contain_file('Puppet CA certificate directory').with(
'ensure' => 'directory',
'path' => '/usr/local/share/ca-certificates/puppet'
) }

it { is_expected.to contain_file('Puppet CA certificate').with(
'ensure' => 'absent',
'path' => '/usr/local/share/ca-certificates/puppet/puppet-ca.crt'
) }

it { is_expected.to contain_exec('Update CA certificates').with(
'command' => 'update-ca-certificates',
'path' => [ '/usr/local/bin', '/usr/bin', '/usr/sbin', '/bin'],
'refreshonly' => true
) }

it { is_expected.to contain_augeas('Disable CA certificate foobar').that_notifies('Exec[Update CA certificates]') }
it { is_expected.to contain_file('Puppet CA certificate').that_notifies('Exec[Update CA certificates]') }
end

context "with disabled_ca_certificates => ['badcert', 'expiredcert'] and publiq_development_root_ca => true" do
Expand Down