Skip to content

III-6888 - Fix add language icons for all selected events#817

Merged
brampauwelyn merged 3 commits intomainfrom
feature/III-6888
Nov 13, 2025
Merged

III-6888 - Fix add language icons for all selected events#817
brampauwelyn merged 3 commits intomainfrom
feature/III-6888

Conversation

@brampauwelyn
Copy link
Contributor

@brampauwelyn brampauwelyn commented Nov 10, 2025

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds the ability to apply language icons to offers either by query (all matching results) or by selection (specific selected items), refactoring the existing addLanguageIcons functionality.

Key Changes:

  • Split addLanguageIcons into three functions: a dispatcher and two implementation functions for query-based and selection-based labeling
  • Added addLanguageIconsToActiveQuery() to handle applying language icons to all events matching a query
  • Renamed original logic to addLanguageIconsToSelection()

Issues Found:

  • Critical bug: undefined variable selectedIds causing runtime error

Reviewed Changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/search/ui/search.controller.js Refactored language icon functionality to support both query-based and selection-based labeling
dist/udb3-angular.min.js Minified distribution file with the same changes
dist/udb3-angular.js Unminified distribution file with the same changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@brampauwelyn brampauwelyn merged commit 2bc05ba into main Nov 13, 2025
7 checks passed
@brampauwelyn brampauwelyn deleted the feature/III-6888 branch November 13, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants