III-6888 - Fix add language icons for all selected events#817
Merged
brampauwelyn merged 3 commits intomainfrom Nov 13, 2025
Merged
III-6888 - Fix add language icons for all selected events#817brampauwelyn merged 3 commits intomainfrom
brampauwelyn merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds the ability to apply language icons to offers either by query (all matching results) or by selection (specific selected items), refactoring the existing addLanguageIcons functionality.
Key Changes:
- Split
addLanguageIconsinto three functions: a dispatcher and two implementation functions for query-based and selection-based labeling - Added
addLanguageIconsToActiveQuery()to handle applying language icons to all events matching a query - Renamed original logic to
addLanguageIconsToSelection()
Issues Found:
- Critical bug: undefined variable
selectedIdscausing runtime error
Reviewed Changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/search/ui/search.controller.js | Refactored language icon functionality to support both query-based and selection-based labeling |
| dist/udb3-angular.min.js | Minified distribution file with the same changes |
| dist/udb3-angular.js | Unminified distribution file with the same changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vhande
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Ticket: https://jira.publiq.be/browse/III-6888