Skip to content

III-6844 match apiKeys#2151

Merged
JonasVHG merged 19 commits intomasterfrom
III-6844-match-apikeys
Feb 9, 2026
Merged

III-6844 match apiKeys#2151
JonasVHG merged 19 commits intomasterfrom
III-6844-match-apikeys

Conversation

@JonasVHG
Copy link
Contributor

@JonasVHG JonasVHG commented Feb 3, 2026

Added

  • ClientIdResolver: Add interface to search for clients.
  • KeycloakClientIdResolver: Add interface to search for clients on Keycloakd.
  • matched-apikeys.feature: Acceptance tests.
  • ApiKeysMatchedToClientIds & InMemoryApiKeysMatchedToClientIds: handle matching of apiKeys to clientIds.
  • UnmatchedApiKey: Exception

Changed

  • Authentication/AuthServiceProvider: register ApiKeysMatchedToClientIds.
  • KeycloakServiceProvider: Register clientIdResolver.
  • RequestAuthenticatorMiddleware: Add logging, inject ApiKeysMatchedToClientIds & ClientIdResolver, add logic to match apiKeys to clientIds.
  • features/search/auth.feature: Update apiKey-name.

Related PF


Ticket: https://jira.publiq.be/browse/III-6844

@JonasVHG
Copy link
Contributor Author

JonasVHG commented Feb 3, 2026

@claude please review

claude[bot]

This comment was marked as resolved.

@cultuurnet cultuurnet deleted a comment from claude bot Feb 3, 2026
@JonasVHG
Copy link
Contributor Author

JonasVHG commented Feb 3, 2026

Claude suggested we should also add a CachedClientIdResolver, but I think it would be more prudent to wait till after the switch & we are sure we didn't forget lots of apiKeys.

@JonasVHG JonasVHG marked this pull request as ready for review February 3, 2026 12:44
@lucwollants
Copy link
Contributor

I see a lot of new classes, but I don't see any unit tests? Although I see a new acceptance test, I think we still need unit tests for a sorter feedback loop.

@JonasVHG
Copy link
Contributor Author

JonasVHG commented Feb 3, 2026

I see a lot of new classes, but I don't see any unit tests? Although I see a new acceptance test, I think we still need unit tests for a sorter feedback loop.

My mistake, I've added unit tests.

@JonasVHG JonasVHG merged commit 07ffd8b into master Feb 9, 2026
4 checks passed
@JonasVHG JonasVHG deleted the III-6844-match-apikeys branch February 9, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants