Conversation
Contributor
Author
|
@claude please review |
…ackend into III-6844-match-apikeys
Contributor
Author
|
|
Contributor
|
I see a lot of new classes, but I don't see any unit tests? Although I see a new acceptance test, I think we still need unit tests for a sorter feedback loop. |
Contributor
Author
My mistake, I've added unit tests. |
lucwollants
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ClientIdResolver: Add interface to search forclients.KeycloakClientIdResolver: Add interface to search forclientsonKeycloakd.matched-apikeys.feature: Acceptance tests.ApiKeysMatchedToClientIds&InMemoryApiKeysMatchedToClientIds: handle matching ofapiKeystoclientIds.UnmatchedApiKey: ExceptionChanged
Authentication/AuthServiceProvider: registerApiKeysMatchedToClientIds.KeycloakServiceProvider: RegisterclientIdResolver.RequestAuthenticatorMiddleware: Add logging, injectApiKeysMatchedToClientIds&ClientIdResolver, add logic to matchapiKeystoclientIds.features/search/auth.feature: UpdateapiKey-name.Related PF
Ticket: https://jira.publiq.be/browse/III-6844