Skip to content

III-6978: add theme preview with translations #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alduya merged 5 commits into from
Feb 5, 2026
Merged

III-6978: add theme preview with translations #1159

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b41c55
III-6978: add theme preview with translations
alduya Feb 2, 2026
cad4a75
III-6978: correct the test for possibly empty values
alduya Feb 2, 2026
968ec11
Merge branch 'main' into feature/III-6978-event-preview-theme
alduya Feb 3, 2026
74876b0
Merge branch 'main' into feature/III-6978-event-preview-theme
alduya Feb 3, 2026
90c1466
III-6978: test empty values based on label instead of on numbers
alduya Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/i18n/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1421,6 +1421,7 @@
"labels": {
"title": "Titel",
"type": "Typ",
"theme": "Thema",
"labels": "Labels",
"description": "Beschreibung",
"location": "Wo",
Expand All @@ -1438,6 +1439,7 @@
},
"empty_value": {
"description": "Keine Beschreibung",
"theme": "Kein Thema",
"organiser": "Keine Organisationsinformationen",
"price": "Keine Preisinformation",
"booking": "Keine Reservierungsinformationen",
Expand Down
2 changes: 2 additions & 0 deletions src/i18n/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,6 +1420,7 @@
"labels": {
"title": "Titre",
"type": "Type",
"theme": "Thème",
"labels": "Étiquettes",
"description": "Description",
"location": "Où",
Expand All @@ -1437,6 +1438,7 @@
},
"empty_value": {
"description": "Aucune description",
"theme": "Aucun thème",
"organiser": "Aucune information sur l'organisation",
"price": "Pas d'information du prix",
"booking": "Aucune information sur la réservation",
Expand Down
2 changes: 2 additions & 0 deletions src/i18n/nl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,6 +1477,7 @@
"labels": {
"title": "Titel",
"type": "Type",
"theme": "Thema",
"labels": "Labels",
"description": "Beschrijving",
"location": "Waar",
Expand All @@ -1494,6 +1495,7 @@
},
"empty_value": {
"description": "Geen beschrijving",
"theme": "Geen thema",
"organiser": "Geen organisatie-informatie",
"price": "Geen prijsinformatie",
"booking": "Geen reservatie-informatie",
Expand Down
9 changes: 9 additions & 0 deletions src/pages/events/[eventId]/preview/Preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ const Preview = () => {
);

const typeTerm = terms.find((term) => term.domain === 'eventtype');
const themeTerm = terms.find((term) => term.domain === 'theme');

const description = getLanguageObjectOrFallback<string>(
offer.description,
Expand Down Expand Up @@ -271,6 +272,14 @@ const Preview = () => {
const tableData = [
{ field: t('preview.labels.title'), value: title },
{ field: t('preview.labels.type'), value: typeTerm.label },
{
field: t('preview.labels.theme'),
value: themeTerm ? (
themeTerm.label
) : (
<EmptyValue>{t('preview.empty_value.theme')}</EmptyValue>
),
},
{
field: t('preview.labels.labels'),
value: (
Expand Down
2 changes: 1 addition & 1 deletion src/test/e2e/events/create-calendar-multiple.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ test('create an event with calendarType multiple', async ({
// Validate that some rows have "Geen" when empty
const tableRows = await page.locator('table.table > tbody > tr').count();

const rowsWithGeenValue = [3, 6, 7, 10, 11, 13, 14];
const rowsWithGeenValue = [2, 4, 7, 8, 11, 12, 14, 15];

const secondColumnCells = await page
.locator('table.table > tbody > tr > td:nth-child(2)')
Expand Down
Loading