-
Notifications
You must be signed in to change notification settings - Fork 97
feat: Implement experimental elinux support #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you very much for the PR :) Actually, Cargokit is not a Rinf product. Cargokit is maintained as a separated project by @irondash. Rinf simply uses Git subtree to use Cargokit as part of the package. What do you think about creating a PR at Cargokit? I will be able to include the new changes in Rinf as soon as it gets merged over there. |
Sure :P |
I've also created a PR at Cargokit to assist with the process |
Thank you! |
Hi @Losses, I think we can bypass the upstream branch from Cargokit and add this functionality directly on our side, as there's an issue with the review duration over there. Would this PR still be helpful? If so, I'd be happy to publish a new version with it. |
@temeddix Yeah! Why not! |
@Losses I'm not very familiar with Flutter-ELinux ecosystem, so please pardon me if I miss something. It would be greatly appreciated if we can share some more information together.
P.S. I've been watching your great work on the music player Rune. If you need any help upgrading to Rinf 8, please let me know :) |
I think the answer is yes, I made a PR for flutter-elinux to fix the compatibility with rinf
Absolutely not
I think this is no much difference with normal flutter projects, but it‘s worth to check the source code.
I've only tested on a x86 machine and it compiled successfully. Cross compiling is sheltered since the compiling pipeline of a library I use was broken, but they fixed it several weeks ago. I think I could embark the support of elinux again these days. Raspberry Pi with a small display is enough for testing.
Thanks! But Rune relies on protobuf for the remote control protocol to cover the situation where the UI and Rust logic are not on the same device. If Rinf 8 does not cover this use case, maybe we cannot upgrade it for now. Sad story. |
Thank you for considering adding eLinux as an experimental platform to the readme files! I'd be happy to help make eLinux support stable alongside the other platforms, within the constraints of my available time. |
Thanks! Let's keep in touch. |
This pull request introduces experimental eLinux support to Rinf. While there are still some modifications needed on the Flutter-eLinux side, I have initiated a discussion on this issue: Issue #270.
Given the stringent performance requirements of embedded environments, the performance advantages of Rust can significantly benefit embedded development.