chore(ci): upgrade Rust toolchain from 1.88 to 1.91#688
Open
temeddix wants to merge 13 commits into
Open
Conversation
- Clear CMakeCache.txt and CMakeFiles before Windows builds - Prevents CMake from requesting old VS 16 2019 generator - Allows CMake to auto-detect latest available Visual Studio version - Fixes CI failure introduced with Rust 1.91 upgrade
…ation - Add comprehensive CMake cache cleanup to all Windows workflows - Clean CMakeCache.txt, CMakeFiles/, *.cmake, and cmake_install.cmake - Specify Visual Studio 17 2022 generator explicitly to avoid conflicts - Add missing cleanup to user_app.yaml workflow - Use -ErrorAction SilentlyContinue for robust PowerShell file operations - Update platform-builds.md skill with Windows CMake troubleshooting guidance Resolves Windows CI failures after Rust 1.91 upgrade by preventing CMake generator version conflicts through comprehensive cache cleanup.
- Update CMAKE_GENERATOR from 'Visual Studio 17 2022' to 'Visual Studio 18 2026' in all workflows - Add explicit --cmake-define parameter to flutter build command for additional safety - Fixes CI failures where GitHub runners have VS 18 but Flutter defaults to VS 16 Resolves Visual Studio generator conflicts on Windows CI builds.
…s runners - Flutter 3.24 hardcodes 'Visual Studio 16 2019' generator which fails on GitHub runners that now have Visual Studio 18 (2026) - Flutter 3.27 properly detects available Visual Studio versions - Update Dart version from 3.5 to 3.6 to match Flutter 3.27 Also removes unnecessary CMAKE_GENERATOR workaround from previous commits.
- flutter build windows does not support --cmake-define option - Flutter 3.27 should properly detect Visual Studio 18 on GitHub runners - Clean up unnecessary CMAKE_GENERATOR workaround Co-authored-by: Claude <noreply@anthropic.com>
…ility - windows-latest now uses VS 18 (2026) which Flutter 3.27 doesn't support - windows-2025 still uses VS 2022 (VS 17) which Flutter detects correctly - Keep Flutter at 3.27.4, Dart 3.6 Resolves Windows CI failures by using a runner with compatible VS version.
…ression - Conditional expressions in runs-on are not supported by GitHub Actions - Use matrix.os with explicit runner names (ubuntu-latest, windows-2025, macos-latest) - Pin Windows to windows-2025 which has VS 2022 (compatible with Flutter 3.27) - Rename matrix.runner to matrix.os for clarity Resolves workflow validation errors that prevented jobs from running.
- matrix.os must use full runner names (ubuntu-latest, windows-2025, macos-latest) - Include entries must match the full runner names - This fixes the workflow validation error that prevented jobs from running
…s-2025 Changes: - Upgrade Rust toolchain from 1.88 to 1.91 (cargo-platform 0.3.3 requirement) - Upgrade Flutter from 3.24.0 to 3.27.4 (Dart 3.5 → 3.6) - Pin Windows runner to windows-2025 (has VS 2022 compatible with Flutter) instead of windows-latest (now has VS 18 which Flutter doesn't support) - Add CMake cache cleanup for Windows builds - Update matrix from matrix.runner to matrix.os with explicit runner names Resolves: - Rust 1.91 requirement for cargo-platform 0.3.3 - Windows CI failures due to VS 18 / Flutter 3.24 incompatibility Note: ubuntu/web and macos/web failures are pre-existing (wasm-bindgen threading)
…anup - Use YAML pipe (|) for multi-line run commands on Windows builds - Previous sed replacement broke the YAML syntax Co-authored-by: Claude <noreply@anthropic.com>
…utter - windows-2025 also has VS 18 now, same issue as windows-latest - windows-2022 should have VS 2022 (VS 17) which Flutter 3.27 can detect Co-authored-by: Claude <noreply@anthropic.com>
- Add -C link-arg=--export=__heap_base to RUSTFLAGS - Install wasm-pack and wasm-bindgen-cli with nightly - Fixes wasm build failures on Rust 1.91+ Resolves cunarist#686
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Cause
cargo-platform@0.3.3requires Rust 1.91, causingwasm-packbuild failures on Rust 1.88.0.Impact